feat: add ERC20FlashMint extension #407
Conversation
Ifechukwudaniel
requested review from
bidzyyys,
qalisander and
0xNeshi
as code owners
✅ Deploy Preview for contracts-stylus canceled.
|
✅ Deploy Preview for contracts-stylus canceled.
|
|
This is my initial draft |
There was a problem hiding this comment.
Hi @Ifechukwudaniel!
Thanks for the contribution!
The PR overall looks good, let's polish it a bit
Co-authored-by: Nenad <[email protected]>
Co-authored-by: Nenad <[email protected]>
chore: fixed tab
Create erc20-flashloan.adoc
chore: fixes
|
@0xNeshi what do you think about the new implementation for the extension |
| /// | ||
| /// Returns a boolean value indicating whether the operation succeeded. | ||
| /// | ||
| /// In order to have [`IErc3156FlashLender::flash_loan`] exposed in ABI, you |
There was a problem hiding this comment.
This section should be at the end of rust docs for the function.
There was a problem hiding this comment.
There's an existing thread related to this, see #407 (comment)
There was a problem hiding this comment.
I would not include benchmarks as they do not cover everything. I suggest removing this part at all, wdyt @qalisander?
There was a problem hiding this comment.
If re-entrancy is not needed for this PR I would not include this change. Wdyt @qalisander @0xNeshi?
There was a problem hiding this comment.
I see if the reentrant feature is enabled in sdk, call gets unsafe
NOTE: It is impossible to write any unit tests until it is possible to mock
contract::address()in tests (see OpenZeppelin/stylus-test-helpers#5).Resolves #355
PR Checklist